Introduce PHP 8.4 support #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k00ni
changed the title
k00ni
changed the title
Usage of xml_set_object is deprecated in PHP 8.4 in favor of using xml_set_* functions with string method names. Because we already do that the xml_set_object call could be removed without any problems. Link to the offical deprecation information for PHP 8.4: https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names
k00ni
commented
Oct 24, 2024
| @@ -94,7 +94,6 @@ protected function initXMLParser() | |||
| xml_set_element_handler($parser, [$this, 'startElementHandler'], [$this, 'endElementHandler']); | |||
| xml_set_character_data_handler($parser, [$this, 'cdataHandler']); | |||
| xml_set_start_namespace_decl_handler($parser, [$this, 'newNamespaceHandler']); | |||
| xml_set_object($parser, $this); | |||
There was a problem hiding this comment.
Just for reference: aa98fe9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, because PHP 8.4 is not even in alpha yet.